Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/esciencecenter-digital-skills/python-intermediate-development/compare/md-outputs..md-outputs-PR-8 The following changes were observed in the rendered markdown documents: What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2025-11-17 20:19:13 +0000 |
sjvrijn
left a comment
There was a problem hiding this comment.
Good stuff! Commented a few fixes and suggestions so far.
Co-authored-by: Sander van Rijn <svr003@gmail.com>
thanks @fnattino ! I applied most of your comments. Feel free to have another look! |
jhidding
left a comment
There was a problem hiding this comment.
Excellent work! I think a reference to the Python Packaging User Guide could be more prominent. It is now mentioned at the end, but maybe also at the beginning as the goto reference on the subject?
As regards the MkDocs Github action exercise suggestion, I think it could be nice to demo, but as an exercise would overload the amount of things people need to learn. There's a lot that comes together there, and no new concepts being tested.
Thanks! I added a callout session metioning this guide at the begining. |
Auto-generated via `{sandpaper}`
Source : 46bb9c8
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2025-11-17 20:20:48 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 585e9b8
Branch : main
Author : Ou Ku <o.ku@esciencecenter.nl>
Time : 2025-11-17 20:19:35 +0000
Message : Merge pull request #8 from esciencecenter-digital-skills/7_update_section_4_software_sustainability
Update section 4
Auto-generated via `{sandpaper}`
Source : 46bb9c8
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2025-11-17 20:20:48 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 585e9b8
Branch : main
Author : Ou Ku <o.ku@esciencecenter.nl>
Time : 2025-11-17 20:19:35 +0000
Message : Merge pull request #8 from esciencecenter-digital-skills/7_update_section_4_software_sustainability
Update section 4
Auto-generated via `{sandpaper}`
Source : 46bb9c8
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2025-11-17 20:20:48 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 585e9b8
Branch : main
Author : Ou Ku <o.ku@esciencecenter.nl>
Time : 2025-11-17 20:19:35 +0000
Message : Merge pull request #8 from esciencecenter-digital-skills/7_update_section_4_software_sustainability
Update section 4
Auto-generated via `{sandpaper}`
Source : 46bb9c8
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2025-11-17 20:20:48 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 585e9b8
Branch : main
Author : Ou Ku <o.ku@esciencecenter.nl>
Time : 2025-11-17 20:19:35 +0000
Message : Merge pull request #8 from esciencecenter-digital-skills/7_update_section_4_software_sustainability
Update section 4
Auto-generated via `{sandpaper}`
Source : 46bb9c8
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2025-11-17 20:20:48 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 585e9b8
Branch : main
Author : Ou Ku <o.ku@esciencecenter.nl>
Time : 2025-11-17 20:19:35 +0000
Message : Merge pull request #8 from esciencecenter-digital-skills/7_update_section_4_software_sustainability
Update section 4
Auto-generated via `{sandpaper}`
Source : 46bb9c8
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2025-11-17 20:20:48 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 585e9b8
Branch : main
Author : Ou Ku <o.ku@esciencecenter.nl>
Time : 2025-11-17 20:19:35 +0000
Message : Merge pull request #8 from esciencecenter-digital-skills/7_update_section_4_software_sustainability
Update section 4
Auto-generated via `{sandpaper}`
Source : 46bb9c8
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2025-11-17 20:20:48 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 585e9b8
Branch : main
Author : Ou Ku <o.ku@esciencecenter.nl>
Time : 2025-11-17 20:19:35 +0000
Message : Merge pull request #8 from esciencecenter-digital-skills/7_update_section_4_software_sustainability
Update section 4
Auto-generated via `{sandpaper}`
Source : 46bb9c8
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2025-11-17 20:20:48 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 585e9b8
Branch : main
Author : Ou Ku <o.ku@esciencecenter.nl>
Time : 2025-11-17 20:19:35 +0000
Message : Merge pull request #8 from esciencecenter-digital-skills/7_update_section_4_software_sustainability
Update section 4
Auto-generated via `{sandpaper}`
Source : 46bb9c8
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2025-11-17 20:20:48 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 585e9b8
Branch : main
Author : Ou Ku <o.ku@esciencecenter.nl>
Time : 2025-11-17 20:19:35 +0000
Message : Merge pull request #8 from esciencecenter-digital-skills/7_update_section_4_software_sustainability
Update section 4
Auto-generated via `{sandpaper}`
Source : 46bb9c8
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2025-11-17 20:20:48 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 585e9b8
Branch : main
Author : Ou Ku <o.ku@esciencecenter.nl>
Time : 2025-11-17 20:19:35 +0000
Message : Merge pull request #8 from esciencecenter-digital-skills/7_update_section_4_software_sustainability
Update section 4
Auto-generated via `{sandpaper}`
Source : 46bb9c8
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2025-11-17 20:20:48 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 585e9b8
Branch : main
Author : Ou Ku <o.ku@esciencecenter.nl>
Time : 2025-11-17 20:19:35 +0000
Message : Merge pull request #8 from esciencecenter-digital-skills/7_update_section_4_software_sustainability
Update section 4
Auto-generated via `{sandpaper}`
Source : 46bb9c8
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2025-11-17 20:20:48 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 585e9b8
Branch : main
Author : Ou Ku <o.ku@esciencecenter.nl>
Time : 2025-11-17 20:19:35 +0000
Message : Merge pull request #8 from esciencecenter-digital-skills/7_update_section_4_software_sustainability
Update section 4
Auto-generated via `{sandpaper}`
Source : 46bb9c8
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2025-11-17 20:20:48 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 585e9b8
Branch : main
Author : Ou Ku <o.ku@esciencecenter.nl>
Time : 2025-11-17 20:19:35 +0000
Message : Merge pull request #8 from esciencecenter-digital-skills/7_update_section_4_software_sustainability
Update section 4
Auto-generated via `{sandpaper}`
Source : 46bb9c8
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2025-11-17 20:20:48 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 585e9b8
Branch : main
Author : Ou Ku <o.ku@esciencecenter.nl>
Time : 2025-11-17 20:19:35 +0000
Message : Merge pull request #8 from esciencecenter-digital-skills/7_update_section_4_software_sustainability
Update section 4
Auto-generated via `{sandpaper}`
Source : 46bb9c8
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2025-11-17 20:20:48 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 585e9b8
Branch : main
Author : Ou Ku <o.ku@esciencecenter.nl>
Time : 2025-11-17 20:19:35 +0000
Message : Merge pull request #8 from esciencecenter-digital-skills/7_update_section_4_software_sustainability
Update section 4
Auto-generated via `{sandpaper}`
Source : 46bb9c8
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2025-11-17 20:20:48 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 585e9b8
Branch : main
Author : Ou Ku <o.ku@esciencecenter.nl>
Time : 2025-11-17 20:19:35 +0000
Message : Merge pull request #8 from esciencecenter-digital-skills/7_update_section_4_software_sustainability
Update section 4
Auto-generated via `{sandpaper}`
Source : 46bb9c8
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2025-11-17 20:20:48 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 585e9b8
Branch : main
Author : Ou Ku <o.ku@esciencecenter.nl>
Time : 2025-11-17 20:19:35 +0000
Message : Merge pull request #8 from esciencecenter-digital-skills/7_update_section_4_software_sustainability
Update section 4
Fix #7
Now 4.2 focuses more on "re-use", including topics: documentation, pyproject.toml, cff file, license
4.3 focuses more one "release", including topics: version tagging, packaging.
Major changes:
4.1 Code review
4.2 Preparing Software for Reuse
mkdocsto the docmentation part. Referencing: https://carpentries-incubator.github.io/good-practices-lesson/instructor/3-documentation.htmlpyproject.tomlfilecfffilemain, since this is not a good practice.4.3 Code Release and Packaging
uv